Bug Having login prompt issues

[bk95ta931]

Running a custom style when you click login the prompt won't show if your viewing any thread. It will however work if your on the forum index or any other index. Disable the mod and works fine

 

[Fillip H.]

Hi there,

Your site is actually listed on our piracy tracker as having an illegal version of Advanced Post Thanks / Like and DragonByte SEO - we checked manually and there are indeed unlicensed Pro files for these products on your server.

For obvious reasons we are unable to support people using illegal versions of our software, please purchase licenses for these products to use them legally.

If you do not respect our work enough to use a legal version, at least respect your own time and ours enough to not waste it asking for support for pirated copies.

Regards,

 

[bk95ta931]

Um lol you may want to go back and check your said files as it's not no bootleg pro version. It was downloaded from here or vbulletin.org. Honestly some way to get support claiming someone installed something illegal. So either your server needs fixed or the files as I never touched it. Even more then welcome to get server access/admin access to prove it.

 

[bk95ta931]

No create addtional buttons



Don't see any of the pro features either here...



So back to the question at hand how to fix the original issue. You fix your files and I will swap the likes part out or you can have access to do so. Doesn't bother me any.

 

[Fillip H.]

The following JS errors are present on your Show Thread page:

TypeError: $(...).live is not a function	$('a.close, #mask').live('click', function() {

TypeError: myLeftColumn is null var myLeftHeight = myLeftColumn.offsetHeight;

TypeError: $(...).nivoSlider is not a function	$("#slider").nivoSlider({

Your forum is also loading multiple instances of jQuery without the use of noConflict, which is also a cause for problems. The problem lies with the way your skin and/or mods implement jQuery.

 

[bk95ta931]

The issue is only there when I enable the seo plugin so how would it be a issue in the style if is fine without the seo plugin? Where did you also find the above errors? I will turn the plugin off if you mind to check again. Another note figure out why it's flagged for having pro files when I don't and package is from the light version here? Only thing I noticed is no copyright showing which I never touched.

 

[Fillip H.]

I found the errors in the browser's error console (Cmd+I in Safari on Mac, F12 in Chrome and Firefox).

We've received no such reports from anyone else running that style, leading me to believe the cause is a conflict between another mod and DBSEO that creates JS errors, which then in turn breaks the login box. Could you try disabling all other modifications, leaving only DBSEO enabled?

 

[bk95ta931]

I figured that out a little bit ago, I also had more errors then that as I reverted some of the updates to the templates done by the author. So reinstalled all the styles and turned off all the mods where the above issues were still there. So went digging and got rid of the first changing the below.

$('a.close, #mask').live('click', function() { 
	  $('#mask , .login-popup').fadeOut(300 , function() {
		$('#mask').remove();  
	});

to

$('a.closet, #mask').bind('click', function() { 
	  $('#mask , .login-popup').fadeOut(300 , function() {
		$('#mask').remove();  
	});

The other issue from what I gather is from not using .noConflict some where in the below code that I can't figure out

<script type="text/javascript">
    $(window).load(function () {
        $("#slider").nivoSlider({
        captionOpacity: 1.0,
        pauseTime: 10000
        });
    });
</script>

<script type="text/javascript">
$(document).ready(function() {
	$('a.login-window').click(function() {
		
		var loginBox = $(this).attr('href');

		$(loginBox).fadeIn(300);
		
		var popMargTop = ($(loginBox).height() + 24) / 2; 
		var popMargLeft = ($(loginBox).width() + 24) / 2; 
		
		$(loginBox).css({ 
			'margin-top' : -popMargTop,
			'margin-left' : -popMargLeft
		});
		
		$('body').append('<div id="mask"></div>');
		$('#mask').fadeIn(300);
		
		return false;
	});
	
	$('a.closet, #mask').bind('click', function() { 
	  $('#mask , .login-popup').fadeOut(300 , function() {
		$('#mask').remove();  
	}); 
	return false;
	});
});
</script>

If I knew support for this style was this bad I would have never bought it. Though looks like since 4.2.2 version all the issues came about.

 

[Fillip H.]

Are you sure your theme was updated for vB 4.2.2? If it was created for an earlier version, and you're relying on the vB auto template merging tool in order to update it, it may not work correctly.

 

[bk95ta931]

To be honest no I'm not sure it will work with .2.2 as the install xml was for 2.1 so had to change it. I did however get all the issues fixed besides one if you want to check it now. From what I figured out it was loading jquery a couple of times. Fixing none of the issues so far has cured anything that I've noticed. The below is the error I have no idea how to fix.

Uncaught TypeError: Cannot read property 'offsetHeight' of nullscript.js:8

 

[Fillip H.]

Are you sure that script.js is required? It seems to be extremely poorly coded.

 

[bk95ta931]

Well from what I seen digging around what it was doing is in the newest jquery. So removed the code for the script out of the header where seems to work the same and I get no errors at all now but same login issue.

 

[Fillip H.]

I'm still seeing multiple JS errors on the page.

If you would PM me with an AdminCP account (make sure to set the admin permissions correctly if creating a temporary new account), I can look into this for you

 

[bk95ta931]

Should be none anywhere but one is thrown clicking login in a thread. If there is more it is something in the built in adsense code as doesn't do it all the time. Turn it off and issue goes away even on the stock skin

 

[Fillip H.]

I have resolved the issue on your skin, it is unfortunately going to be incompatible with DBSEO because it's using what I can only describe as a piss-poor way of opening the login box.

The problem is that when you click the "Log In" link, it will take the contents of the "href" attribute without any form of validation or sanitation, and search for a HTML node that matches that content.

In other words, if it says href="#login-box" it works, but this is bad for SEO because it means "link to another part of the document on this page".

DBSEO will, as is intended, change it to href="full-url-here#login-box", because that is correct for SEO. Naturally, this causes the login box script to completely capitulate.

Instead, I changed href="#login-box" to href="javascript://" in the navbar template, and changed var loginBox = $(this).attr('href'); to var loginBox = '#login-box'; in the headinclude template.

I wish I was still young enough to be shocked at the fact that someone coded the skin in this way...