Legacy Possible handing of email address issue better

[ZeroHour]

Hi
We purchased this a while ago and for various reasons have never been able to actually enable it.
I just updated to V2 and noticed your CP pages mentioning that you have 2 modes now, one with a ; required to tag and one without.
I have taken a quick gander at your code and am more curios why you have this issue with email addresses as I can think of what see as a simple solution (although I have not read through all the code)
The function usertag_match_all pulls strpos of the @, now the next lines could easily check to things to prevent email address and other issues.
Simply check is strpos is 0 first which means the tag is at the start of the post then if it is not 0 check the char to strpos -1 is " "
That way you have removed any chance of the email addresses being picked up as they would have anything but a " " and your also handing if the tag is start as you may get errors checking strpos 0 - 1.
It should also be pretty fast as your not running multiple strpos searches.
It seems like a simple solution to me but like I say I have not finished my audit yet for which I do for all addons before going live.

Thoughts?

Cheers

 

[Fillip H.]

It's definitely something we'll try to solve for a future version - there simply wasn't enough time before this release to risk introducing new bugs by altering code we know works

The other problem with the ;-less tagging is that it's also more performance intensive as it literally needs to check several more potential usernames to find a match - and sometimes it grabs the wrong one which would be totally beyond our control.

This is obviously more of a problem on larger forums where the range of usernames that revolve around the same base name (think a Final Fantasy forum and permutations of "Sephiroth").

That's why we decided to go with a solution we knew would be completely successful